Skip to content

docs: Add changelog for composite primary key support in dbt export #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 17, 2025
Merged

docs: Add changelog for composite primary key support in dbt export #900

merged 3 commits into from
Oct 17, 2025

Conversation

@toshifumisuga
Copy link
Contributor

@toshifumisuga toshifumisuga commented Sep 25, 2025 •
edited
Loading

Summary

This PR adds the changelog that was missing in the previous one.
#898

  • Tests pass
  • ruff format
Tests and ruff result 
(datacontract-cli)datacontract-cli toshifumi.suga$ pytest tests/test_export_dbt_models.py -v
================================================================================================================= test session starts =================================================================================================================
platform darwin -- Python 3.11.13, pytest-8.4.2, pluggy-1.6.0 -- /Users/toshifumi.suga/Documents/dev/datacontract-cli/.venv/bin/python3
cachedir: .pytest_cache
rootdir: /Users/toshifumi.suga/Documents/dev/datacontract-cli
configfile: pyproject.toml
plugins: xdist-3.8.0, anyio-4.10.0, typeguard-4.4.4
collected 6 items                                                                                                                                                                                                                                     

tests/test_export_dbt_models.py::test_cli PASSED                                                                                                                                                                                                [ 16%]
tests/test_export_dbt_models.py::test_to_dbt_models PASSED                                                                                                                                                                                      [ 33%]
tests/test_export_dbt_models.py::test_to_dbt_models_with_server PASSED                                                                                                                                                                          [ 50%]
tests/test_export_dbt_models.py::test_to_dbt_models_with_no_model_type PASSED                                                                                                                                                                   [ 66%]
tests/test_export_dbt_models.py::test_to_dbt_models_with_model_level_composite_primary_key PASSED                                                                                                                                               [ 83%]
tests/test_export_dbt_models.py::test_to_dbt_models_with_single_column_primary_key PASSED                                                                                                                                                       [100%]

================================================================================================================== 6 passed in 1.79s ==================================================================================================================
(datacontract-cli)datacontract-cli toshifumi.suga$ ruff check tests/test_export_dbt_models.py 
All checks passed!
(datacontract-cli)datacontract-cli toshifumi.suga$
  • README.md updated (if relevant)
  •  CHANGELOG.md entry added

@toshifumisuga toshifumisuga changed the title fix changelog docs: Add changelog for composite primary key support in dbt export Sep 25, 2025
@toshifumisuga
Copy link
Contributor Author

The CI is failing with errors that I believe are unrelated to my changes. I'd appreciate it if you could verify.
Let me know if any action is required from me

toshifumisuga
toshifumisuga commented Sep 25, 2025
View reviewed changes
@toshifumisuga toshifumisuga marked this pull request as ready for review September 25, 2025 06:31
@jochenchrist
Copy link
Contributor

The CI is failing with errors that I believe are unrelated to my changes. I'd appreciate it if you could verify. Let me know if any action is required from me

Yes, correct. Sorry for inconvienience, I will fix main.

@jochenchrist jochenchrist merged commit 17c129b into datacontract:main Oct 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@toshifumisuga @jochenchrist